Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: print TB status message to logs [MLG-1119] #8642

Merged
merged 1 commit into from
Jan 4, 2024
Merged

chore: print TB status message to logs [MLG-1119] #8642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions harness/determined/exec/tensorboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,13 @@ def start_tensorboard(
raise_if_dead(tensorboard_process)

# Check if we have reached a timeout without downloading any files
if tb_fetch_manager.get_num_fetched_files() == 0 and time.time() > stop_time:
raise RuntimeError("No new files were fetched before the timeout.")

if tb_fetch_manager.get_num_fetched_files() == 0:
if time.time() > stop_time:
raise RuntimeError("No new files were fetched before the timeout.")
else:
# TODO: This should trigger an actual task state change (DET-10001).
# For now, just print a message to the logs.
print("TensorBoard is waiting for metrics.", flush=True)
time.sleep(TICK_INTERVAL)

finally:
Expand Down