Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove out of place spinner at dashboard page #8668

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Jan 9, 2024

Description

Fix the issue that the buttons on the dashboard page are out of place during page load.

Before:
Screenshot 2024-01-08 at 2 24 23 PM

After:
Screenshot 2024-01-08 at 2 23 49 PM

This PR only remove the out of place button, and should follow up with utilizing multiple spinners WEB-1898

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1902

@gt2345 gt2345 requested a review from a team as a code owner January 9, 2024 17:28
@gt2345 gt2345 requested a review from EmilyBonar January 9, 2024 17:28
@cla-bot cla-bot bot added the cla-signed label Jan 9, 2024
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 06976aa
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/659d822c4280a600080ee44e
😎 Deploy Preview https://deploy-preview-8668--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (926a6de) 51.46% compared to head (06976aa) 47.27%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8668      +/-   ##
==========================================
- Coverage   51.46%   47.27%   -4.19%     
==========================================
  Files         882      569     -313     
  Lines      156044   117644   -38400     
  Branches     2085     2085              
==========================================
- Hits        80302    55613   -24689     
+ Misses      74254    60543   -13711     
  Partials     1488     1488              
Flag Coverage Δ
harness ?
web 53.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 313 files with indirect coverage changes

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gt2345 gt2345 merged commit 38e6825 into main Jan 11, 2024
78 of 89 checks passed
@gt2345 gt2345 deleted the gt/1902-dashboard-spinners branch January 11, 2024 17:57
@dannysauer dannysauer modified the milestone: 0.27.1 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants