Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: break out stopping... states from stopped states in webui #8672

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Jan 9, 2024

Description

This fixes an issue where experiments that were stopping for one reason or another showed as stopped.

Test Plan

submit an experiment
on the experiment's detail page, cancel the experiment
the experiment state should show up as stopping before updating to stopped.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

WEB-1913

@ashtonG ashtonG requested a review from a team as a code owner January 9, 2024 20:11
@cla-bot cla-bot bot added the cla-signed label Jan 9, 2024
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d19433b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a01fdd1f33b8000883f54a

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9dc4fc8) 51.46% compared to head (d19433b) 47.27%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8672      +/-   ##
==========================================
- Coverage   51.46%   47.27%   -4.19%     
==========================================
  Files         882      569     -313     
  Lines      156047   117643   -38404     
  Branches     2084     2088       +4     
==========================================
- Hits        80302    55613   -24689     
+ Misses      74255    60540   -13715     
  Partials     1490     1490              
Flag Coverage Δ
harness ?
web 53.77% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/ExperimentIcons.tsx 86.66% <83.33%> (-0.61%) ⬇️

... and 313 files with indirect coverage changes

@ashtonG ashtonG changed the title break out stopping... states from stopped states in webui fix: break out stopping... states from stopped states in webui Jan 10, 2024
Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This fixes an issue where experiments that were stopping for one reason
or another showed as stopped.
@ashtonG ashtonG merged commit 127cf98 into main Jan 11, 2024
74 of 85 checks passed
@ashtonG ashtonG deleted the fix/WEB-1913/status-update branch January 11, 2024 17:55
@dannysauer dannysauer modified the milestone: 0.27.1 Feb 6, 2024
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
This fixes an issue where experiments that were stopping for one reason
or another showed as stopped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants