Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trial APIs --local should respect .detignore. [MLG-1352] #8683

Merged
merged 4 commits into from
Jan 12, 2024

purge rglob comment & `__pycache__` filter.

35413d7
Select commit
Loading
Failed to load commit list.
Merged

fix: Trial APIs --local should respect .detignore. [MLG-1352] #8683

purge rglob comment & `__pycache__` filter.
35413d7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 12, 2024 in 0s

51.48% (+0.01%) compared to 38e6825

View this Pull Request on Codecov

51.48% (+0.01%) compared to 38e6825

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (38e6825) 51.46% compared to head (35413d7) 51.48%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8683      +/-   ##
==========================================
+ Coverage   51.46%   51.48%   +0.01%     
==========================================
  Files         884      886       +2     
  Lines      156121   156170      +49     
  Branches     2088     2088              
==========================================
+ Hits        80352    80397      +45     
- Misses      74282    74286       +4     
  Partials     1487     1487              
Files Coverage Δ
harness/determined/common/context.py 91.52% <100.00%> (-1.27%) ⬇️
harness/determined/common/v1file_utils.py 100.00% <100.00%> (ø)
harness/tests/filetree.py 93.54% <100.00%> (+2.63%) ⬆️
harness/tests/test_imports.py 97.95% <100.00%> (-0.23%) ⬇️
harness/tests/test_util.py 100.00% <100.00%> (ø)
harness/determined/util.py 73.75% <75.00%> (-0.17%) ⬇️
harness/determined/common/detignore.py 93.10% <93.10%> (ø)

... and 6 files with indirect coverage changes