chore: standardize oidc/saml group & display attribute names in helm config #8689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
|
Docsite preview being generated for this PR. |
carolinaecalderon
force-pushed
the
helm-edits-user-auth
branch
from
4f774fa
to
0b3952a
Compare
carolinaecalderon
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8689 +/- ##
==========================================
- Coverage 51.32% 51.31% -0.01%
==========================================
Files 894 894
Lines 156712 156712
Branches 2096 2096
==========================================
- Hits 80425 80424 -1
- Misses 74792 74793 +1
Partials 1495 1495
Flags with carried forward coverage won't be shown. Click here to find out more. |
carolinaecalderon
force-pushed
the
carolinac/helm-doc-edits-user-auth
branch
from
fd06108
to
30ad071
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change groupsClaimName -> groupsAttributeName, and displayNameCLaimName -> displayNameAttributeName in OIDC. This standardizes the fields with OIDC
Test Plan
Commentary (optional)
This will break EE -- so there needs to be an extra PR to be landed shortly after this is merged (& ee is rebased) that changes the relevant variable names in the OIDC ID Token Claims struct.
Checklist
docs/release-notes/.See Release Note for details.
Ticket