Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playwright fix #8699

Merged
merged 2 commits into from
Jan 17, 2024
Merged

fix: playwright fix #8699

merged 2 commits into from
Jan 17, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Jan 16, 2024

Description

fix react e2e test failure https://app.circleci.com/pipelines/github/determined-ai/determined/49978/workflows/c3146d0f-01a7-4efa-8c3e-4206f537ca74/jobs/2191778

Error: browserType.launch: Executable doesn't exist at /ms-playwright/webkit-1944/pw_run.sh
    ╔═════════════════════════════════════════════════════════════════════════╗
    ║ Looks like Playwright Test or Playwright was just installed or updated. ║
    ║ Please run the following command to download new browsers:              ║
    ║                                                                         ║
    ║     npx playwright install                                              ║
    ║                                                                         ║
    ║ <3 Playwright Team                                                      ║
    ╚═════════════════════════════════════════════════════════════════════════╝

Test Plan

  • Check if react e2e test passes

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Jan 16, 2024
Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 6953426
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65a813d53769e30008374c3e
😎 Deploy Preview https://deploy-preview-8699--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined force-pushed the ci/playwright-fix branch 3 times, most recently from 32623c2 to 421cca4 Compare January 16, 2024 22:58
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c869ce7) 51.51% compared to head (6953426) 51.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8699   +/-   ##
=======================================
  Coverage   51.51%   51.51%           
=======================================
  Files         887      887           
  Lines      156209   156209           
  Branches     2088     2088           
=======================================
+ Hits        80466    80472    +6     
+ Misses      74250    74246    -4     
+ Partials     1493     1491    -2     
Flag Coverage Δ
backend 36.24% <ø> (+0.01%) ⬆️
harness 64.29% <ø> (ø)
web 53.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@keita-determined keita-determined marked this pull request as ready for review January 16, 2024 23:14
@keita-determined keita-determined requested a review from a team as a code owner January 16, 2024 23:14
@keita-determined
Copy link
Contributor Author

keita-determined commented Jan 16, 2024

Unrelated ci, ci/circleci: test-unit-storage, is blocking

fixed

.circleci/real_config.yml Outdated Show resolved Hide resolved
Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this fixes it. Seems to work though, so great! :D

Copy link
Contributor

@hkang1 hkang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@keita-determined keita-determined merged commit 6d3f9ff into main Jan 17, 2024
71 of 85 checks passed
@keita-determined keita-determined deleted the ci/playwright-fix branch January 17, 2024 18:10
erikwilson pushed a commit that referenced this pull request Jan 18, 2024
* fix: playwright fix

* chore: use make command

(cherry picked from commit 6d3f9ff)
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
* fix: playwright fix

* chore: use make command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants