-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: playwright fix #8699
fix: playwright fix #8699
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
32623c2
to
421cca4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8699 +/- ##
=======================================
Coverage 51.51% 51.51%
=======================================
Files 887 887
Lines 156209 156209
Branches 2088 2088
=======================================
+ Hits 80466 80472 +6
+ Misses 74250 74246 -4
+ Partials 1493 1491 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
fixed |
af15227
to
6953426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that this fixes it. Seems to work though, so great! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks!
* fix: playwright fix * chore: use make command (cherry picked from commit 6d3f9ff)
* fix: playwright fix * chore: use make command
Description
fix react e2e test failure https://app.circleci.com/pipelines/github/determined-ai/determined/49978/workflows/c3146d0f-01a7-4efa-8c3e-4206f537ca74/jobs/2191778
Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket