-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix CreateExperiment for Remote Users #8700
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
salonig23
requested review from
maxrussell
and removed request for
carolinaecalderon
January 17, 2024 00:42
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8700 +/- ##
==========================================
- Coverage 48.95% 45.58% -3.38%
==========================================
Files 634 701 +67
Lines 81788 142197 +60409
Branches 0 2088 +2088
==========================================
+ Hits 40042 64817 +24775
- Misses 40261 75887 +35626
- Partials 1485 1493 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
maxrussell
approved these changes
Jan 17, 2024
salonig23
changed the title
fix: fic CreateExperiment for Remote Users
fix: fix CreateExperiment for Remote Users
Jan 17, 2024
NicholasBlaskey
added
the
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
label
Jan 17, 2024
stoksc
approved these changes
Jan 17, 2024
dai-release bot
pushed a commit
that referenced
this pull request
Jan 17, 2024
(cherry picked from commit f2899cc)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
varlogtim
added a commit
that referenced
this pull request
Oct 18, 2024
I think this was just missed in: #8700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
taskSpec.ExtraEnvVars was not initialized in the case of remote users which was causing a panic whenever the user tried to create an experiment
Test Plan
Log in as a remote user and check if you can create an experiment
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket