fix: use selected checkpoints when registering #8739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikwilson
added
the
to-cherry-pick
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8739 +/- ##
==========================================
- Coverage 47.28% 42.13% -5.15%
==========================================
Files 1045 728 -317
Lines 166788 128185 -38603
Branches 2246 2246
==========================================
- Hits 78860 54012 -24848
+ Misses 87770 74015 -13755
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
hkang1
approved these changes
Jan 24, 2024
| @@ -121,7 +121,7 @@ const RegisterCheckpointModal: React.FC<ModalProps> = ({ | |||
| } catch (e) { | |||
| handleError(e, { | |||
| publicSubject: `Unable to register ${pluralizer(checkpoints.length, 'checkpoint')}.`, | |||
| silent: true, | |||
| silent: false, | |||
There was a problem hiding this comment.
I wonder why this was ever set to true...
dai-release bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
(cherry picked from commit 9f06d35)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We will attempt to register all of the checkpoints on a page for certain views. This PR will use only the selected checkpoints.
Test Plan
Launch an experiment like
det e create ./examples/tutorials/core_api/2_checkpoints.yaml ./examples/tutorials/core_api/.On the experiment checkpoint page click on the three dots icon (far right) to register. Make sure experiment registers successfully and that you can change the "Version Name".
Next select multiple checkpoints and perform a bulk action register for two checkpoints.
Then verify the checkpoints are correctly registered in the model registry page.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
WEB-1948