-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expconf flag to force scheduling on a single node/container/pod #8743
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8743 +/- ##
==========================================
- Coverage 47.28% 47.27% -0.01%
==========================================
Files 1045 1045
Lines 166785 166800 +15
Branches 2244 2244
==========================================
- Hits 78857 78855 -2
- Misses 87770 87787 +17
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
"sleep infinity", | ||
], | ||
"request unfulfillable", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much cleaner!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the go & e2e side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the quick turnaround!
Description
Test Plan
e2e_cpu_2a
.Commentary (optional)
currently not supported by slurm due to https://github.com/determined-ai/determined-ee/blob/64ae6c75eb1d5072cb60b1572f394219c0210f57/master/pkg/tasks/dispatcher_task.go#L568
Checklist
docs/release-notes/
.See Release Note for details.
Ticket