Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bring in missing EE helm chart change [ci skip] #8747

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

dannysauer
Copy link
Member

@dannysauer dannysauer commented Jan 24, 2024

Description

This change was initially made in determined-ai/determined-ee@df500801e44a
PR: determined-ai/determined-ee#1121
CC: @carolinaecalderon

I did add documentation in the values file, which was originally missing in EE. Not sure why this parameter is capitalized, since it probably shouldn't be, but cleaning up the helm chart to make it consistent is not within the scope of this PR.

Test Plan

N/A - this'll totally just work (since it's been fine in EE for a while). So confident, I'm skipping CI.

I did run

helm template --set maxSlotsPerPod=2 ./helm/charts/determined/

and validated that there are no parse issues. And then...

sauer@host$ helm template --set maxSlotsPerPod=2 --set oidc.GroupsClaimName=hello --set oidc.enabled=true --set enterpriseEdition=true --set oidc.provider=xxx --set oidc.idpRecipientUrl=xxx --set oidc.idpSsoUrl=xxx --set oidc.clientId=xxx --set oidc.clientSecretName=xxx --set oidc.clientSecretKey=xxx ./helm/charts/determined/ | grep hello

      groups_claim_name: hello

and validated that the parameter works.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 66b376e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65b18529906f6e0008790df2

@dannysauer dannysauer merged commit 2ffc18f into main Jan 25, 2024
13 checks passed
@dannysauer dannysauer deleted the feat/dannys/fix-missing-EE-helm-param branch January 25, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants