Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up extra prints #8755

Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore: clean up extra prints #8755

merged 1 commit into from
Jan 31, 2024

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Jan 25, 2024

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@hamidzr hamidzr requested a review from a team as a code owner January 25, 2024 18:47
@hamidzr hamidzr requested a review from daranday January 25, 2024 18:47
@cla-bot cla-bot bot added the cla-signed label Jan 25, 2024
Copy link

netlify bot commented Jan 25, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 15bfc8e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65b2acdf6a45380008750c2c

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c3650f) 47.40% compared to head (15bfc8e) 47.40%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8755   +/-   ##
=======================================
  Coverage   47.40%   47.40%           
=======================================
  Files        1046     1046           
  Lines      166945   166943    -2     
  Branches     2247     2246    -1     
=======================================
+ Hits        79146    79147    +1     
+ Misses      87640    87637    -3     
  Partials      159      159           
Flag Coverage Δ
backend 41.73% <ø> (+<0.01%) ⬆️
harness 64.36% <ø> (+<0.01%) ⬆️
web 42.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/healthcheck.py 19.64% <ø> (+0.67%) ⬆️

... and 4 files with indirect coverage changes

Copy link
Contributor

@szewaiyuen6 szewaiyuen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hamidzr hamidzr merged commit dfbb926 into main Jan 31, 2024
77 of 88 checks passed
@hamidzr hamidzr deleted the hz-clean-extra-print branch January 31, 2024 18:44
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants