-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: respond with 401 for programmatic requests. #8795
Conversation
to proxied services instead of redirecting those to login page
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8795 +/- ##
=======================================
Coverage 47.72% 47.73%
=======================================
Files 1049 1049
Lines 167238 167239 +1
Branches 2241 2243 +2
=======================================
+ Hits 79815 79830 +15
+ Misses 87265 87251 -14
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I left a couple small comments/questions but nothing blocking.
I also understand if you'd prefer to have someone with more context also take a look. :)
Thanks for the review. I added some tests to check the behavior as well. |
for internal proxied services.
to proxied services instead of redirecting those to login page
https://hpe-aiatscale.atlassian.net/browse/GAS-568?filter=-2
Description
Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket