Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update backend coverage target #8798

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

amandavialva01
Copy link
Contributor

Description

Backend code coverage has increased to about 43%, so increasing the target to 42% (with the same 3% threshold).

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Feb 5, 2024
Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f89188e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65c110dc3c1663000725082f

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65c811c) 47.72% compared to head (f89188e) 47.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8798      +/-   ##
==========================================
- Coverage   47.72%   47.72%   -0.01%     
==========================================
  Files        1049     1049              
  Lines      167258   167258              
  Branches     2243     2243              
==========================================
- Hits        79824    79816       -8     
- Misses      87276    87284       +8     
  Partials      158      158              
Flag Coverage Δ
backend 43.23% <ø> (-0.03%) ⬇️
harness 64.32% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after a week of study. :D

@amandavialva01 amandavialva01 merged commit ba8250a into main Feb 15, 2024
77 of 89 checks passed
@amandavialva01 amandavialva01 deleted the amanda/UpdateCoverageTarget branch February 15, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants