-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add ee helm chart changes to oss #8799
Conversation
✅ Deploy Preview for determined-ui canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good either way, but should the release notes from determined-ai/determined-ee#1186 be moved or duplicated to OSS as well?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8799 +/- ##
===========================================
- Coverage 47.72% 39.77% -7.95%
===========================================
Files 1049 449 -600
Lines 167258 56251 -111007
Branches 2243 0 -2243
===========================================
- Hits 79824 22374 -57450
+ Misses 87276 33877 -53399
+ Partials 158 0 -158
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs release note
2cb5fa9
to
0a6a90b
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking the initiative on this
(cherry picked from commit a1a6e20)
(cherry picked from commit a1a6e20)
Description
Add EE helm chart changes to OSS
Test Plan
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket