Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ee helm chart changes to oss #8799

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

salonig23
Copy link
Contributor

Description

Add EE helm chart changes to OSS

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 0a6a90b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65c145e716a79e0008a7ddb3

Copy link
Member

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good either way, but should the release notes from determined-ai/determined-ee#1186 be moved or duplicated to OSS as well?

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65c811c) 47.72% compared to head (0a6a90b) 39.77%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8799       +/-   ##
===========================================
- Coverage   47.72%   39.77%    -7.95%     
===========================================
  Files        1049      449      -600     
  Lines      167258    56251   -111007     
  Branches     2243        0     -2243     
===========================================
- Hits        79824    22374    -57450     
+ Misses      87276    33877    -53399     
+ Partials      158        0      -158     
Flag Coverage Δ
harness 34.26% <ø> (-30.06%) ⬇️
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 678 files with indirect coverage changes

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs release note

@determined-ci determined-ci requested a review from a team February 5, 2024 20:32
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Feb 5, 2024
@salonig23
Copy link
Contributor Author

Needs release note

Done

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking the initiative on this

@salonig23 salonig23 merged commit a1a6e20 into main Feb 5, 2024
63 of 85 checks passed
@salonig23 salonig23 deleted the add-helm-chart-changes branch February 5, 2024 20:41
@wes-turner wes-turner added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Feb 5, 2024
wes-turner pushed a commit that referenced this pull request Feb 5, 2024
wes-turner pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants