-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add release notes for 0.28.0 #8807
Conversation
Docsite preview being generated for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-0.28.0 #8807 +/- ##
===================================================
- Coverage 44.28% 41.84% -2.44%
===================================================
Files 1018 328 -690
Lines 165186 34301 -130885
Branches 2241 0 -2241
===================================================
- Hits 73154 14354 -58800
+ Misses 91874 19947 -71927
+ Partials 158 0 -158
Flags with carried forward coverage won't be shown. Click here to find out more. |
docs/release-notes.rst
Outdated
Version 0.28.0 | ||
============== | ||
|
||
**Release Date:** February 05, 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
docs/release-notes.rst
Outdated
provisioning), when a ``slots`` request for a notebook, shell, or command cannot be fulfilled, | ||
it'll be rejected. | ||
|
||
- API: The checkpoint download endpoint will now allow the use of `application/x-tar`` as an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a backtick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
docs/release-notes.rst
Outdated
improve performance of the system. A new ``config`` field is added now to the response of | ||
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement. | ||
|
||
If you are not calling the APIs manually there will be no impact to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line should probably go with the previous paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some prior art for 2-paragraph blurbs, but I agree. I like it better that way, too. Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes but lgtm
Docsite preview being generated for this PR. |
1fe79ec
to
cd4c0b3
Compare
|
||
- API: The checkpoint download endpoint will now allow the use of `application/x-tar`` as an | ||
accepted content type in the request. It will provide a response in the form of an uncompressed | ||
tar file, complete with content-length information included in the headers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tar file, complete with content-length information included in the headers. | |
tar file, complete with content length information included in the headers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per OOB communication, leaving as-is.
docs/release-notes.rst
Outdated
improve performance of the system. A new ``config`` field is added now to the response of | ||
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
improve performance of the system. A new ``config`` field is added now to the response of | |
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement. | |
improve performance of the system. The response of ``/api/v1/experiments/{experiment_id}`` now | |
contains a new ``config`` field that can be used as a replacement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Done.
- Experiments: Add ``resources.is_single_node`` option which disallows scheduling the trial across | ||
multiple nodes or pods, and forces it to be scheduled within a single container. If the requested | ||
``slots_per_trial`` count is impossible to fulfill in the cluster, the experiment submission will | ||
be rejected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Experiments: Add ``resources.is_single_node`` option which disallows scheduling the trial across | |
multiple nodes or pods, and forces it to be scheduled within a single container. If the requested | |
``slots_per_trial`` count is impossible to fulfill in the cluster, the experiment submission will | |
be rejected. | |
- Experiments: Add ``resources.is_single_node`` option, which forces trials to be scheduled within | |
single containers rather than across multiple nodes or pods. If the requested ``slots_per_trial`` | |
count is impossible to fulfill in the cluster, the experiment submission will be rejected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is totally better language. Thanks.
docs/release-notes.rst
Outdated
improve performance of the system. A new ``config`` field is added now to the response of | ||
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement. | ||
|
||
If you are not calling the APIs manually there will be no impact to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are not calling the APIs manually there will be no impact to you. | |
If you are not calling the APIs manually, there will be no impact to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Docsite preview being generated for this PR. |
1 similar comment
Docsite preview being generated for this PR. |
ee8dc22
to
7c96da4
Compare
Docsite preview being generated for this PR. |
Add release notes for 0.28.0.
Add release notes for 0.28.0.
Add release notes for 0.28.0.
Add release notes for 0.28.0.