Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release notes for 0.28.0 #8807

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

wes-turner
Copy link
Contributor

Add release notes for 0.28.0.

@cla-bot cla-bot bot added the cla-signed label Feb 6, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Feb 6, 2024
@determined-ci determined-ci requested a review from a team February 6, 2024 17:36
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4b6f57) 44.28% compared to head (cd4c0b3) 41.84%.

❗ Current head cd4c0b3 differs from pull request most recent head ee8dc22. Consider uploading reports for the commit ee8dc22 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-0.28.0    #8807       +/-   ##
===================================================
- Coverage           44.28%   41.84%    -2.44%     
===================================================
  Files                1018      328      -690     
  Lines              165186    34301   -130885     
  Branches             2241        0     -2241     
===================================================
- Hits                73154    14354    -58800     
+ Misses              91874    19947    -71927     
+ Partials              158        0      -158     
Flag Coverage Δ
harness ?
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 691 files with indirect coverage changes

Version 0.28.0
==============

**Release Date:** February 05, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

provisioning), when a ``slots`` request for a notebook, shell, or command cannot be fulfilled,
it'll be rejected.

- API: The checkpoint download endpoint will now allow the use of `application/x-tar`` as an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a backtick

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

improve performance of the system. A new ``config`` field is added now to the response of
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement.

If you are not calling the APIs manually there will be no impact to you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should probably go with the previous paragraph

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some prior art for 2-paragraph blurbs, but I agree. I like it better that way, too. Fixed.

Copy link
Contributor

@azhou-determined azhou-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes but lgtm

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.


- API: The checkpoint download endpoint will now allow the use of `application/x-tar`` as an
accepted content type in the request. It will provide a response in the form of an uncompressed
tar file, complete with content-length information included in the headers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tar file, complete with content-length information included in the headers.
tar file, complete with content length information included in the headers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per OOB communication, leaving as-is.

Comment on lines 46 to 47
improve performance of the system. A new ``config`` field is added now to the response of
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
improve performance of the system. A new ``config`` field is added now to the response of
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement.
improve performance of the system. The response of ``/api/v1/experiments/{experiment_id}`` now
contains a new ``config`` field that can be used as a replacement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Done.

Comment on lines +28 to +31
- Experiments: Add ``resources.is_single_node`` option which disallows scheduling the trial across
multiple nodes or pods, and forces it to be scheduled within a single container. If the requested
``slots_per_trial`` count is impossible to fulfill in the cluster, the experiment submission will
be rejected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Experiments: Add ``resources.is_single_node`` option which disallows scheduling the trial across
multiple nodes or pods, and forces it to be scheduled within a single container. If the requested
``slots_per_trial`` count is impossible to fulfill in the cluster, the experiment submission will
be rejected.
- Experiments: Add ``resources.is_single_node`` option, which forces trials to be scheduled within
single containers rather than across multiple nodes or pods. If the requested ``slots_per_trial``
count is impossible to fulfill in the cluster, the experiment submission will be rejected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally better language. Thanks.

improve performance of the system. A new ``config`` field is added now to the response of
``/api/v1/experiments/{experiment_id}`` that can be used as a replacement.

If you are not calling the APIs manually there will be no impact to you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you are not calling the APIs manually there will be no impact to you.
If you are not calling the APIs manually, there will be no impact to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@determined-ci determined-ci requested a review from a team February 6, 2024 19:50
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

1 similar comment
@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@determined-ci
Copy link
Collaborator

Docsite preview being generated for this PR.
You can (eventually) find the generated docsite here.

@wes-turner wes-turner merged commit 518ea77 into release-0.28.0 Feb 6, 2024
13 of 58 checks passed
@wes-turner wes-turner deleted the relnotes-0.28.0 branch February 6, 2024 20:16
wes-turner added a commit that referenced this pull request Feb 6, 2024
Add release notes for 0.28.0.
wes-turner added a commit that referenced this pull request Feb 6, 2024
Add release notes for 0.28.0.
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Add release notes for 0.28.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants