Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix error on terminating experiments on restart #8837

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

Description

Was getting some errors in logs related to being unable to update the trial view.

Fix these errors and add a test

Test Plan

Integration test

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 0e43030
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65cbc9d1939a5b00083a4211

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a13863) 47.69% compared to head (0e43030) 47.70%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8837      +/-   ##
==========================================
+ Coverage   47.69%   47.70%   +0.01%     
==========================================
  Files        1065     1065              
  Lines      169611   169611              
  Branches     2238     2240       +2     
==========================================
+ Hits        80897    80917      +20     
+ Misses      88556    88536      -20     
  Partials      158      158              
Flag Coverage Δ
backend 43.52% <100.00%> (+0.05%) ⬆️
harness 64.11% <ø> (ø)
web 42.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/db/postgres_experiments.go 48.66% <100.00%> (+2.81%) ⬆️

... and 1 file with indirect coverage changes

@NicholasBlaskey NicholasBlaskey enabled auto-merge (squash) February 13, 2024 19:58
@NicholasBlaskey NicholasBlaskey merged commit a4dbc03 into main Feb 13, 2024
69 of 84 checks passed
@NicholasBlaskey NicholasBlaskey deleted the fix_some_logs branch February 13, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants