chore: bump CLI GitPython dependency from 2.1.11 to 3.1.3 [DET-3499] #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI didn't break, so my guess is this is ok. |
stoksc
approved these changes
Jul 21, 2020
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
) * Added new image * Testing new image on circleci builds * A lot of commits; added most of the functioanlity for make pbscluster * Exporting variables by default in slurmcluster.sh * Added a check so that if the image resource manager is different than the specified program will exit * Added comments to new check compat script * Adding back deleted files by accident * Got rid of check-compatibility script. Instead, there is a images.conf in /terraform that holds the boot disk names for PBS and SLURM and updates the boot_disk.tfvar accordingly * [ALLGCP] Getting rid of debugging code in config.yaml * [ALLGCP] Changed script so that flags are passed in to both slurmcluster and terraform build * [ALLGCP] Updating how update-images script works with the new images.conf * [ALLGCP] Refactoring: resource manager -> workload manager * [ALLGCP] Adding back useful comments * [ALLGCP] Refactoring resource -> workload in config.yaml * [ALLGCP] Adding advisory comments to slurmcluster.sh * [ALLGCP] Accidentally changed a variable to uppercase, changing back * [ALLGCP] Accidentally changed a variable to uppercase, changing back * fixed workload manager env variable * [ALLGCP] Adding some formatting changes * [ALLGCP] Adding Rigs suggestions to making openpbs version number a variable in the ansible playbook and made the openpbs target directory without the version suffix * [ALLGCP] 'Manually' rebasing with the latest commit to main to fix terraform lock race * [ALLGCP] Ansible playbook does not allow hyphens in variable names so replacing with underscores * [ALLGCP] Got rid of extraneous flag from slurmcluster.sh * [ALLGCP] Making formatting and comment changes to generate-pkr-vars script * [ALLGCP] Updated images.conf * [ALLGCP] Changed slurmcluster.yaml resourec -> workload manager * [ALLGCP] Made usage sections better p2 * [ALLGCP] Adding extra pytest flags to pbs suites * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Adding some README to the packer directory * [ALLGCP] Change the -r flag to -w * [ALLGCP] Change the -r flag to -w in config.yaml * [ALLGCP] Changed enroot runtime path * [ALLGCP] Changed enroot runtime path command to not expand the whoami * [ALLGCP] Deleting VPC network upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Deleting firewall rule upon creation as well * [ALLGCP] Changing ENROOT_RUNTIME_PATH back to /tmp/launcher in slurmcluster.yaml * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Skipping tests that fail on PBS * [ALLGCP] Trying to debug random error at the end of PBS pytestsw * [ALLGCP] Updating documentation * [ALLGCP] Now parameters only have to be passed to top-level makefile per Jerry's reccomendation * [ALLGCP] Added comment to complex grep command that grabs the zone.default from terraform/variables.tf in config.yaml Also changed tf_lock -> TF_LOCK in config.yaml * [ALLGCP] Changed all instances of workload manager variable to be semantically the same (WORKLOAD_MANAGER) * [ALLGCP] Updated README to get rid of erroneous formatting. Based it off the formatting for a man page * [ALLGCP] Updated tools/slurm/packer/README to add more clarifcation of WORKLOAD_MANAGER option * [ALLGCP] Added back requires: build-go to ALLGCP tests * [ALLGCP] Adding Jerry's reccomended comments in ansible-playbook.yaml * [ALLGCP] Changed the -v flag to -t to make its function less ambiguous * [ALLGCP] Updated the way that images in images.conf are updated from update-variables.sh * [ALLGCP] Deleted the weird note in packer/README * [ALLGCP] Got rid of extraneous hyphens in slurmcluster.sh * [ALLGCP] Added more informative error message in update-variables * [ALLGCP] Added comment in slurmcluster.sh --------- Co-authored-by: CharlesTran1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.