docs: tweak dev prerequisites #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamidzr
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
I didn't know but it looks like some distros don't ship NPM with Node.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857986
CONTRIBUTING.md
Outdated
| - Node (>= 12) | ||
| - NPM |
There was a problem hiding this comment.
Suggested change
| - NPM | |
| - NPM (>= 6.12) |
There was a problem hiding this comment.
neilconway
force-pushed
the
contributing-tweak
branch
from
5e266a7
to
3077e16
Compare
stoksc
pushed a commit
that referenced
this pull request
Jul 20, 2023
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
eecsliu
pushed a commit
that referenced
this pull request
Jul 24, 2023
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
eecsliu
pushed a commit
that referenced
this pull request
Apr 18, 2024
…version (#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
eecsliu
pushed a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
…version (determined-ai#947) * [ALLGCP] Added a way for the default CPU image to be checked and default to what is already there * [ALLGCP] Added new images slurm and pbs * [ALLGCP] Testing out of date image * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Added correct logic for when image is out of date * [ALLGCP] Testing with out-of-date images final * [ALLGCP] Got rid of debugging in scripts * [ALLGCP] Added a wait for VM creation step that is less trivial than a constant sleep * [ALLGCP] Wait for VM creation jhob checks every 5 seconds now * [ALLGCP] Changing formatting of wait for vm time * [ALLGCP] Adding some more context to logging in slurmcluster.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to install
npmto be able to build from source on a new machine. We also don't work with Python >= 3.8 right now.