fix: naming for model registry CLI commands and entities [DET-3767] #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilconway
reviewed
Aug 3, 2020
| @@ -97,16 +97,19 @@ def get_versions(self, order_by: ModelOrderBy = ModelOrderBy.DESC) -> List[Check | |||
| ) | |||
| data = resp.json() | |||
|
|
|||
| for v in data["modelVersions"]: | |||
master/internal/api_model.go
Outdated
| return resp, a.paginate(&resp.Pagination, &resp.Versions, req.Offset, req.Limit) | ||
| a.sort(resp.ModelVersions, req.OrderBy, req.SortBy, apiv1.GetModelVersionsRequest_SORT_BY_VERSION) | ||
| for _, v := range resp.ModelVersions { | ||
| fmt.Printf("v: %v, uuid: %v\n", v.Version, v.Checkpoint.Uuid) |
aaron276h
reviewed
Aug 4, 2020
aaron276h
approved these changes
Aug 4, 2020
sidneyw
force-pushed
the
feat/registry-api-fixes
branch
from
2ed697e
to
2be39bd
Compare
sidneyw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
versiontomodel_versionin the REST APIChanges underscores to hyphens in the CLI
Test Plan