feat: add archived status column to Experiment list [DET-3540] #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
reviewed
Jul 29, 2020
webui/react/src/components/Table.tsx
Outdated
Comment on lines
110
to
111
| if (!record.archived) return null; | ||
| return <CheckOutlined />; |
There was a problem hiding this comment.
suggestion: this can use the ternary operator:
return record.archived ? <CheckOutlined /> : null;
hkang1
reviewed
Jul 29, 2020
| @@ -75,7 +76,7 @@ export const taskTypeRenderer: TaskRenderer = (_, record) => ( | |||
| </Tooltip> | |||
| ); | |||
|
|
|||
| /* Experiemnt Table Column Renderers */ | |||
| /* Experiment Table Column Renderers */ | |||
hkang1
reviewed
Jul 29, 2020
| align: 'center', | ||
| render: experimentArchivedRenderer, | ||
| sorter: (a: ExperimentItem, b: ExperimentItem): number => | ||
| (a.archived === b.archived)? 0 : a.archived? 1 : -1, |
There was a problem hiding this comment.
nit: nice, love the nested ternary. Don't have to this now but if we see another boolean based sorting use case, we can abstract into a dedicated booleanSorter. How about this for a little better legibility?
(a.archived === b.archived) ? 0 : (a.archived ? 1 : -1),
hkang1
approved these changes
Jul 29, 2020
armandmcqueen
force-pushed
the
add_archived_col_to_experiment_list
branch
from
e1f8906
to
9dab7f9
Compare
armandmcqueen
force-pushed
the
add_archived_col_to_experiment_list
branch
from
e7f19e0
to
bb4d8cd
Compare
stoksc
pushed a commit
that referenced
this pull request
Oct 17, 2023
azhou-determined
pushed a commit
that referenced
this pull request
Dec 7, 2023
wes-turner
pushed a commit
that referenced
this pull request
Feb 2, 2024
rb-determined-ai
pushed a commit
that referenced
this pull request
Feb 29, 2024
amandavialva01
pushed a commit
that referenced
this pull request
Mar 18, 2024
eecsliu
added a commit
that referenced
this pull request
Apr 18, 2024
eecsliu
added a commit
to determined-ai/determined-release-testing
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add column to Experiment list that uses a checkmark to indicate whether the Experiment is archived.
Test Plan
Tested manually.
Tested sorting - when using descending order,
archived=Trueis at the top.Commentary (optional)
I found a checkmark in Ant Design that I think looks good, but let me know if we want to go with Yes/No text for now.