style: polish experiment detail [DET-3517, DET-3621] #974
Conversation
hkang1
force-pushed
the
3621-polish-experiment-detail
branch
3 times, most recently
from
db11c31
to
b350776
Compare
hkang1
changed the title
hkang1
force-pushed
the
3621-polish-experiment-detail
branch
from
b350776
to
9b2aea1
Compare
hkang1
force-pushed
the
3621-polish-experiment-detail
branch
from
d7b3348
to
a2552e7
Compare
|
could we separate moving the files around from polishing and changing their content (in terms of PR)? the github UI doesn't give us a good diff of what's happening and what's changing update: actually I could go commit by commit as you have them nice and separate. |
There was a problem hiding this comment.
The experiment page is looking so good now!
some style nits: I feel like we could use a higher contrast on the info labels.
would be nice to have truncation on the experiment description and maybe a full tooltip? or maybe the full description could appear in infobox.
| @@ -42,7 +42,7 @@ const TrialDetailsComp: React.FC = () => { | |||
| const message = isNotFound(trial.error) ? `Trial ${trialId} not found.` | |||
| : `Failed to fetch trial ${trialId}.`; | |||
| return ( | |||
| <Page hideTitle title="Not Found"> | |||
| <Page id="not-found"> | |||
There was a problem hiding this comment.
nit: not a new addition here but not-found wouldn't be always accurate here.
There was a problem hiding this comment.
updated the id to page-error-message to better reflect what the Page component is representing.
| @@ -92,36 +90,42 @@ const ExperimentActions: React.FC<Props> = ({ | |||
| }; | |||
|
|
|||
| const actionButtons: ConditionalButton<ExperimentDetails>[] = [ | |||
| { button: <Button key="fork" type="primary" onClick={onClick[Action.Fork]}>Fork</Button> }, | |||
| { | |||
There was a problem hiding this comment.
sidenote: IMO if the buttons were defined separately we wouldn't have generated as big a diff with just reordering them
hkang1
force-pushed
the
3621-polish-experiment-detail
branch
from
b23ab8c
to
f728f38
Compare
Description
Test Plan
Commentary (optional)