Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix make check #977

Merged
merged 1 commit into from
Jul 30, 2020
Merged

fix: fix make check #977

merged 1 commit into from
Jul 30, 2020

Conversation

rb-determined-ai
Copy link
Member

@rb-determined-ai rb-determined-ai commented Jul 30, 2020 •
edited
Loading 

pytest recently released major version 6.0. It introduces some
significant typing fixes. pytest 6.0 requires mypy==0.750, but is
actually developed against mypy==0.780.

This supports pytest 6.0 and explicitly requires pytest>=6.0.1 and
mypy==0.780.

Test Plan

CI should pass again.

@cla-bot cla-bot bot added the cla-signed label Jul 30, 2020
aaron276h
aaron276h approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@aaron276h aaron276h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work fixing this so fast!

@rb-determined-ai
Copy link
Member Author

looks like I jumped the gun. Pytest definitely seems to be the thing that changed, there's lots of e2e breakages as well.

@rb-determined-ai
fix: fix make check
003017b 
pytest recently released major version 6.0. It introduces some
significant typing fixes. pytest 6.0 requires mypy==0.750, but is
actually developed against mypy==0.780.

This supports pytest 6.0 and explicitly requires pytest>=6.0.1 and
mypy==0.780.
@rb-determined-ai rb-determined-ai changed the title fix: fix make -C harness check fix: fix make check Jul 30, 2020
@rb-determined-ai rb-determined-ai merged commit 767fb01 into determined-ai:master Jul 30, 2020
@rb-determined-ai rb-determined-ai deleted the fix-make-check branch July 30, 2020 17:25
rb-determined-ai pushed a commit that referenced this pull request Oct 5, 2023
@CharlesTran1 @rb-determined-ai
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
c14bd6a 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[e2e_tests changes only]
rb-determined-ai pushed a commit that referenced this pull request Oct 10, 2023
@CharlesTran1 @rb-determined-ai
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
64edda1 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[e2e_tests changes only]
stoksc pushed a commit that referenced this pull request Oct 17, 2023
@CharlesTran1 @NicholasBlaskey
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
6c28a83 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

* [ALLGCP] chore: reverted experiment.py changes and moved to test_slurm.
rb-determined-ai pushed a commit that referenced this pull request Oct 27, 2023
@CharlesTran1 @rb-determined-ai
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
31c81bd 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[e2e_tests changes only]
rb-determined-ai pushed a commit that referenced this pull request Oct 31, 2023
@CharlesTran1 @rb-determined-ai
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
3ce6873 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[e2e_tests changes only]
rb-determined-ai pushed a commit that referenced this pull request Nov 2, 2023
@CharlesTran1 @rb-determined-ai
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
8dcd856 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[e2e_tests changes only]
rb-determined-ai pushed a commit that referenced this pull request Nov 2, 2023
@CharlesTran1 @rb-determined-ai
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
393d0b5 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[e2e_tests changes only]
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
@CharlesTran1 @azhou-determined
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
d7f49e9 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[excluding e2e_tests changes]
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
@CharlesTran1 @determined-ci
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
95ed9f0 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[excluding e2e_tests changes]
@dannysauer dannysauer added this to the 0.12.13 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
@CharlesTran1 @djanicekpach
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
a4c9407 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[excluding e2e_tests changes]
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
@CharlesTran1 @determined-ci
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
de5eac0 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[excluding e2e_tests changes]
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
@CharlesTran1 @determined-ci
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
b2f3465 
…itly listing test names in circleci. (#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[excluding e2e_tests changes]
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
@CharlesTran1 @eecsliu
ci: FE-133 Configure non agent slurm/pbs tests to skip without explic…
539e71b 
…itly listing test names in circleci. (determined-ai#977)

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: trying to figure out home issue. updated docs

* [ALLGCP] fix: removed temp changes

* [ALLGCP] fix: merge with pending_reason test

* [ALLGCP] fix: merge error

* [ALLGCP] ci: added the agent skip to pending reason test and removed flag from pytest

* [ALLGCP] added skip flag back into znode agent test

* [ALLGCP] ci: moved skip method to experiment.py. Added more detailed error message

* [ALLGCP] chore: changed method name to be consistent with rest

[excluding e2e_tests changes]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron276h aaron276h aaron276h approved these changes

Assignees

@rb-determined-ai rb-determined-ai

Labels
cla-signed
Projects
None yet
Milestone
0.12.13
Development

Successfully merging this pull request may close these issues.
3 participants
@rb-determined-ai @aaron276h @dannysauer