Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alway use restored allocation request time for queue recording #9799

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamidzr
Copy link
Member

@hamidzr hamidzr commented Aug 5, 2024

Ticket

Description

we fixed various issue with zero start_time times that were set as start of queue period for task stats. this
fixes another issue where restored tasks would report the original job's start/submission time for this purpose.

#9745 (comment)

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 33d479b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66b13c2fc55e1b0008a232e9

@hamidzr hamidzr requested a review from gt2345 August 5, 2024 20:58
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.84%. Comparing base (cdbbedd) to head (33d479b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9799      +/-   ##
==========================================
- Coverage   54.06%   53.84%   -0.23%     
==========================================
  Files        1261      736     -525     
  Lines      155621   102624   -52997     
  Branches     3508     3507       -1     
==========================================
- Hits        84140    55253   -28887     
+ Misses      71335    47225   -24110     
  Partials      146      146              
Flag Coverage Δ
backend 43.77% <ø> (-1.15%) ⬇️
harness 56.06% <ø> (-16.56%) ⬇️
web 53.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 656 files with indirect coverage changes

@hamidzr hamidzr changed the title alway use restored allocation request time for queue recording fix: alway use restored allocation request time for queue recording Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant