Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model version name overflow on mobile [ET-384] #9827

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Aug 15, 2024

Ticket

ET-384

Description

Test Plan

Go to a Model Version page, shrink your viewport to ~mobile width, and confirm that the buttons (including overflow button) are present.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 55a4cd2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66c4a923110cf20008d8ebf0
😎 Deploy Preview https://deploy-preview-9827--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 50.13%. Comparing base (c0ca659) to head (55a4cd2).
Report is 22 commits behind head on main.

Files Patch % Lines
...c/pages/ModelVersionDetails/ModelVersionHeader.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9827      +/-   ##
==========================================
- Coverage   54.36%   50.13%   -4.24%     
==========================================
  Files        1261      938     -323     
  Lines      155811   126479   -29332     
  Branches     3539     3539              
==========================================
- Hits        84711    63411   -21300     
+ Misses      70962    62930    -8032     
  Partials      138      138              
Flag Coverage Δ
harness ?
web 53.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/pages/ModelVersionDetails/ModelVersionHeader.tsx 0.00% <0.00%> (ø)

... and 323 files with indirect coverage changes

@EmilyBonar EmilyBonar merged commit 2b1856a into main Aug 20, 2024
82 of 95 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/model-version-name branch August 20, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants