-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent loading issues with ipynb files #9850
Conversation
This fixes an issue where a parse error occurs when the user selects an ipynb file in the experiment code viewer. The file content updates as an effect of the selected file path changing. Because the effect happens after render, the editor is briefly rendered with the wrong content. To fix this, the file content is now keyed with the path. when the path doesn't match, we assume the content hasn't loaded yet. Further error handling fixes should be introduced in this pr upstream in hew.
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9850 +/- ##
==========================================
- Coverage 54.38% 50.15% -4.23%
==========================================
Files 1261 938 -323
Lines 155770 126437 -29333
Branches 3540 3543 +3
==========================================
- Hits 84711 63414 -21297
+ Misses 70921 62885 -8036
Partials 138 138
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that I don't see the error toast anymore. useAsync
is also a cleaner way to load the data, so this gets two birds with one stone
Ticket
ET-741
Description
This fixes an issue where a parse error occurs when the user selects an ipynb file in the experiment code viewer. The file content updates as an effect of the selected file path changing. Because the effect happens after render, the editor is briefly rendered with the wrong content. To fix this, the file content is now keyed with the path. when the path doesn't match, we assume the content hasn't loaded yet.
Further error handling fixes should be introduced in this pr upstream in hew.
Test Plan
Checklist
docs/release-notes/
See Release Note for details.