Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new ruamel yaml APIs #9882

Merged
merged 2 commits into from
Aug 29, 2024
Merged

fix: use new ruamel yaml APIs #9882

merged 2 commits into from
Aug 29, 2024

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented Aug 29, 2024

Ticket

Description

ruamel changed their APIs and previous method call no longer exists.

Test Plan

run MNIST locally: go to examples/tutorials/mnist_pytorch and run python3 train.py, make sure it runs and exits successfully.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 7bd16a7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66d0b7974a6fec000878b4d2

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.23%. Comparing base (a605f00) to head (7bd16a7).

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9882       +/-   ##
===========================================
- Coverage   54.70%   44.23%   -10.48%     
===========================================
  Files        1261      658      -603     
  Lines      156681    67002    -89679     
  Branches     3596        0     -3596     
===========================================
- Hits        85710    29636    -56074     
+ Misses      70840    37366    -33474     
+ Partials      131        0      -131     
Flag Coverage Δ
harness 40.34% <ø> (-32.29%) ⬇️
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 693 files with indirect coverage changes

@azhou-determined azhou-determined merged commit d54713c into main Aug 29, 2024
81 of 96 checks passed
@azhou-determined azhou-determined deleted the fix-yaml-mnist branch August 29, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants