feat: support updating web hook url [MD-482]

[jgongd]

Ticket

MD-482

Description

Users can edit the url of a webhook.

Test Plan

CI passes.

Checklist

• Changes have been manually QA'd
• New features have been approved by the corresponding PM
• User-facing API changes have the "User-facing API Change" label
• Release notes have been added as a separate file under docs/release-notes/
  See Release Note for details.
• Licenses have been included for new code which was copied and/or modified from any external code

[netlify]

✅ Deploy Preview for determined-ui ready!

Name	Link
🔨 Latest commit	c8fc477
🔍 Latest deploy log	https://app.netlify.com/sites/determined-ui/deploys/66df7c152f3c8000083c75b9
😎 Deploy Preview	https://deploy-preview-9890--determined-ui.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

Attention: Patch coverage is 10.71429% with 100 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (c1499ac) to head (c8fc477).

Files with missing lines	Patch %	Lines
webui/react/src/components/WebhookEditModal.tsx	0.00%	89 Missing and 1 partial ⚠️
webui/react/src/pages/WebhookList.tsx	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9890      +/-   ##
==========================================
+ Coverage   54.57%   59.18%   +4.61%     
==========================================
  Files        1250      751     -499     
  Lines      156266   104452   -51814     
  Branches     3598     3597       -1     
==========================================
- Hits        85283    61824   -23459     
+ Misses      70852    42496   -28356     
- Partials      131      132       +1     

Flag	Coverage Δ
backend	43.80% <ø> (-1.35%)	⬇️
harness	72.75% <ø> (ø)
web	54.33% <10.71%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
webui/react/src/services/api.ts	97.79% <100.00%> (+0.01%)	⬆️
webui/react/src/services/apiConfig.ts	74.18% <100.00%> (+0.07%)	⬆️
webui/react/src/pages/WebhookList.tsx	0.00% <0.00%> (ø)
webui/react/src/components/WebhookEditModal.tsx	0.00% <0.00%> (ø)

... and 500 files with indirect coverage changes

[gt2345]

Looks good! Just some minor comments.

[gt2345]

nit: I'd prefer reusing determined.webhook.v1.Webhook

[gt2345]

LGTM

[salonig23]

is it expected that you receive requests to edit non-TaskLog triggers? Also do we want to exit the function as soon as we encounter the first non-Task log type trigger?

[jgongd]

is it expected that you receive requests to edit non-TaskLog triggers?

Yes. I'm skipping it because only TaskLog triggers are stored in cache. https://github.com/determined-ai/determined/pull/9890/files/c08e8b902b779999dee41e3d7b287f67453d8750#diff-3ea86afd178c30910e3fdbc3f40b950a61d566b1e70bc4d932bbba3e693c2802R71-R78

Also do we want to exit the function as soon as we encounter the first non-Task log type trigger?

Good catch! I shouldn't exit the function.

[salonig23]

LGTM!

[jgongd]

The failures in CI test-intg-master are known flakes.