Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate command task wait page over to react [DET-3704] #990

Merged
merged 3 commits into from
Aug 3, 2020
Merged

chore: migrate command task wait page over to react [DET-3704] #990

merged 3 commits into from
Aug 3, 2020

Conversation

hkang1
Copy link
Contributor

@hkang1 hkang1 commented Jul 31, 2020 •
edited by jira bot
Loading

Description

Screen Shot 2020-07-31 at 3 46 03 PM

Updated the style to fit better with our react pages.

Test Plan

Commentary (optional)

@cla-bot cla-bot bot added the cla-signed label Jul 31, 2020
@hkang1 hkang1 requested a review from hamidzr July 31, 2020 21:48
hamidzr
hamidzr reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the elm files for this one?

@hamidzr
Copy link
Member

hamidzr commented Aug 3, 2020

could you remove the elm files for this one?

so we know what is actually being served and that it's served correctly

@hamidzr hamidzr assigned hkang1 and unassigned hamidzr Aug 3, 2020
@hkang1
Copy link
Contributor Author

hkang1 commented Aug 3, 2020

could you remove the elm files for this one?

so we know what is actually being served and that it's served correctly

Great call

@hkang1 hkang1 assigned hamidzr and unassigned hkang1 Aug 3, 2020
hamidzr
hamidzr approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works :) I personally prefer the big background determined logo.

@hamidzr hamidzr assigned hkang1 and unassigned hamidzr Aug 3, 2020
@hkang1 hkang1 merged commit ea95102 into determined-ai:master Aug 3, 2020
@hkang1 hkang1 deleted the 3704-migrate-waitjs branch August 3, 2020 22:27
stoksc pushed a commit that referenced this pull request Oct 17, 2023
@ioga @NicholasBlaskey
ci: no ml-sys codeowners for EE. (#990)
e03f3b8
azhou-determined pushed a commit that referenced this pull request Dec 7, 2023
@ioga @azhou-determined
ci: no ml-sys codeowners for EE. (#990)
bc7adc8
wes-turner pushed a commit that referenced this pull request Feb 2, 2024
@ioga @determined-ci
ci: no ml-sys codeowners for EE. (#990)
6a6d609
@dannysauer dannysauer added this to the 0.12.13 milestone Feb 6, 2024
rb-determined-ai pushed a commit that referenced this pull request Feb 29, 2024
@ioga @djanicekpach
ci: no ml-sys codeowners for EE. (#990)
7b5a750
amandavialva01 pushed a commit that referenced this pull request Mar 18, 2024
@ioga @determined-ci
ci: no ml-sys codeowners for EE. (#990)
47e7456
eecsliu pushed a commit that referenced this pull request Apr 18, 2024
@ioga @determined-ci
ci: no ml-sys codeowners for EE. (#990)
fe69978
eecsliu pushed a commit to determined-ai/determined-release-testing that referenced this pull request Apr 22, 2024
@ioga @eecsliu
ci: no ml-sys codeowners for EE. (determined-ai#990)
dbe4f58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamidzr hamidzr hamidzr approved these changes

Assignees

@hkang1 hkang1

Labels
cla-signed
Projects
None yet
Milestone
0.12.13
Development

Successfully merging this pull request may close these issues.
3 participants
@hkang1 @hamidzr @dannysauer