feat: enable list pages [DET-3705] #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkang1
force-pushed
the
3705-enable-list-pages
branch
from
c80921a
to
72482bb
Compare
hamidzr
reviewed
Aug 4, 2020
hkang1
force-pushed
the
3705-enable-list-pages
branch
from
72482bb
to
824c707
Compare
hamidzr
reviewed
Aug 4, 2020
hamidzr
reviewed
Aug 4, 2020
hkang1
force-pushed
the
3705-enable-list-pages
branch
5 times, most recently
from
d1c18c1
to
4d5e216
Compare
hkang1
force-pushed
the
3705-enable-list-pages
branch
from
4d5e216
to
9cd15bc
Compare
armandmcqueen
approved these changes
Aug 10, 2020
| @@ -100,6 +100,9 @@ | |||
| .icon-star::before { | |||
| content: "\e90a"; | |||
| } | |||
| .icon-tasks::before { | |||
| content: "\e920"; | |||
There was a problem hiding this comment.
Why do we use ::before here?
There was a problem hiding this comment.
pseudoelements are common for inserting text through css if that's what you're asking : )
There was a problem hiding this comment.
great question: it's a pattern typically used to display icons via font icon using a pseudo-element ::before. Pseudo elements are reserved for visual elements only and ignored for things like accessibility (like aria-label and title)
hamidzr
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UPDATE: PR 991 landed
This PR needs to land after PR 991
Test Plan
Commentary (optional)