-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement Delete config policies API handlers #9927
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9927 +/- ##
=======================================
Coverage 54.50% 54.51%
=======================================
Files 1253 1252 -1
Lines 156630 156654 +24
Branches 3599 3600 +1
=======================================
+ Hits 85368 85396 +28
+ Misses 71129 71125 -4
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adfea53
to
6e22a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - great work!
) | ||
|
||
func TestDeleteWorkspaceConfigPolicies(t *testing.T) { | ||
// TODO (CM-520): Make test cases for experiment config policies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice callout / reminder.
) | ||
|
||
// WorkloadType is the type of workload (experiment or NTSC) that the task config policy applies to. | ||
type WorkloadType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a great idea. Just a little ahead of its time, perhaps. Thanks for keeping the codebase clean!
19df360
to
17bdc3c
Compare
17bdc3c
to
3a40afa
Compare
Ticket
CM-488
Description
Implement API handlers for Delete config policies for workspace-level and global scopes.
Test Plan
CI passes (automated testing).
Checklist
docs/release-notes/
See Release Note for details.