Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky workspace test #9931

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: flaky workspace test #9931

merged 1 commit into from
Sep 13, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Sep 13, 2024

Ticket

Description

Fixes issue with View Toggle test on Workspace List unnecessarily expecting a specific workspace.

Test Plan

No additional release party testing required. Automated tests should pass.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested a review from a team as a code owner September 13, 2024 17:14
@cla-bot cla-bot bot added the cla-signed label Sep 13, 2024
Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 9ccb626
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66e472e77bc0630008792830
😎 Deploy Preview https://deploy-preview-9931--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're so fast CALM DOWN PLEASE

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.07%. Comparing base (5b2275f) to head (9ccb626).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (5b2275f) and HEAD (9ccb626). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (5b2275f) HEAD (9ccb626)
harness 8 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9931      +/-   ##
==========================================
- Coverage   59.18%   54.07%   -5.12%     
==========================================
  Files         751      442     -309     
  Lines      104462    75867   -28595     
  Branches     3597     3597              
==========================================
- Hits        61825    41022   -20803     
+ Misses      42505    34713    -7792     
  Partials      132      132              
Flag Coverage Δ
harness ?
web 54.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 309 files with indirect coverage changes

@johnkim-det johnkim-det merged commit 6f36969 into main Sep 13, 2024
88 of 100 checks passed
@johnkim-det johnkim-det deleted the flaky-workspace-test branch September 13, 2024 18:03
salonig23 pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants