Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase datagrid rightclick timeout/ reduce worker count #9951

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Sep 17, 2024

Ticket

ET-678

Description

This attempts to deflake the datagrid action pause tests by increasing the rightclick timeout. I'm skeptical that this will deflake because the error message on timeout says that it's performing the click action, meaning it's already located the element and it's visible and clickable.

In addition, we reduce the worker count by one to prevent further timeout issues stemming from the machine throttling.

Test Plan

No manual testing needed -- ci should be green.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@ashtonG ashtonG requested a review from a team as a code owner September 17, 2024 21:11
@cla-bot cla-bot bot added the cla-signed label Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit db73fe1
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ec8193e6994400087ed20b
😎 Deploy Preview https://deploy-preview-9951--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.43%. Comparing base (02e302f) to head (84a50fa).
Report is 35 commits behind head on main.

Current head 84a50fa differs from pull request most recent head db73fe1

Please upload reports for the commit db73fe1 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9951      +/-   ##
==========================================
- Coverage   54.50%   50.43%   -4.08%     
==========================================
  Files        1252      943     -309     
  Lines      156668   128073   -28595     
  Branches     3600     3601       +1     
==========================================
- Hits        85396    64593   -20803     
+ Misses      71139    63347    -7792     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 309 files with indirect coverage changes

@ashtonG ashtonG force-pushed the ci/ET-678/increased-datagrid-rightclick-timeout branch from 84a50fa to db73fe1 Compare September 19, 2024 19:54
@ashtonG ashtonG changed the title ci: increase datagrid rightclick timeout ci: increase datagrid rightclick timeout/ reduce worker count Sep 20, 2024
@ashtonG ashtonG merged commit c8b1910 into main Sep 25, 2024
92 of 105 checks passed
@ashtonG ashtonG deleted the ci/ET-678/increased-datagrid-rightclick-timeout branch September 25, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants