Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show search progress in run table #9976

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented Sep 24, 2024

Ticket

ET-804

Description

Test Plan

Go to the Runs table of a populated project. Ensure that the "Search Progress" column is populated.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@EmilyBonar EmilyBonar requested a review from a team as a code owner September 24, 2024 15:15
@cla-bot cla-bot bot added the cla-signed label Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 5b480bc
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66f2d875d571050008d38024
😎 Deploy Preview https://deploy-preview-9976--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilyBonar EmilyBonar requested review from gt2345 and removed request for hkang1 September 24, 2024 15:15
@EmilyBonar EmilyBonar added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 50.44%. Comparing base (924f663) to head (5b480bc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
webui/react/src/pages/FlatRuns/columns.ts 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9976      +/-   ##
==========================================
- Coverage   54.51%   50.44%   -4.07%     
==========================================
  Files        1256      947     -309     
  Lines      156700   128104   -28596     
  Branches     3603     3604       +1     
==========================================
- Hits        85424    64622   -20802     
+ Misses      71143    63349    -7794     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.31% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
webui/react/src/pages/FlatRuns/columns.ts 18.63% <0.00%> (+0.06%) ⬆️

... and 309 files with indirect coverage changes

Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmilyBonar EmilyBonar merged commit a8effe8 into main Sep 24, 2024
80 of 94 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/fix-run-progress branch September 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants