Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import missing time module #9985

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Sep 25, 2024

Ticket

Description

I noticed that the docs/deploy/upload.py uses time.time_ns() on line 148 which requires an import, otherwise we are getting an exception. This PR imports this missing module.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

Signed-off-by: Emmanuel Ferdman <[email protected]>
Copy link

cla-bot bot commented Sep 25, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @emmanuel-ferdman on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@determined-ci determined-ci requested a review from a team September 25, 2024 07:29
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Sep 25, 2024
@sirredbeard
Copy link
Contributor

@cla-bot[bot] check

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
Copy link

cla-bot bot commented Sep 25, 2024

The cla-bot has been summoned, and re-checked this pull request!

@sirredbeard
Copy link
Contributor

CLA signed, authorizing tests.

Copy link
Member

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sirredbeard sirredbeard enabled auto-merge (squash) September 30, 2024 18:20
@ioga ioga disabled auto-merge September 30, 2024 19:13
@ioga ioga merged commit 25ca6d0 into determined-ai:main Sep 30, 2024
69 of 75 checks passed
@ioga
Copy link
Contributor

ioga commented Sep 30, 2024

@emmanuel-ferdman thank you for your PR! which automated or AI tool did you use to catch this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants