fix: display archived column for runs and searches #9987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the archived column to the columns api. It also updates the flat runs view to handle showing the archived state of runs and ensures the archived definition matches the show archived behavior.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9987 +/- ##
==========================================
- Coverage 54.51% 54.51% -0.01%
==========================================
Files 1256 1256
Lines 156695 156720 +25
Branches 3603 3605 +2
==========================================
+ Hits 85426 85430 +4
- Misses 71136 71157 +21
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ashtonG
requested review from
AmanuelAaron
and removed request for
amandavialva01
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EmilyBonar
approved these changes
Sep 26, 2024
| Column: "archived", | ||
| DisplayName: "Archived", | ||
| Location: projectv1.LocationType_LOCATION_TYPE_RUN, | ||
| Type: projectv1.ColumnType_COLUMN_TYPE_UNSPECIFIED, // no boolean type |
There was a problem hiding this comment.
q: would it be possible to add a boolean type in this pr, or is that out of scope?
There was a problem hiding this comment.
Let's handle it separately because parentArchived in runs + metadata is also affected by that change.
| @@ -60,9 +61,9 @@ const EXCLUDED_SEARCH_DEFAULT_COLUMNS: RunColumn[] = [ | |||
|
|
|||
| export type RunColumn = (typeof runColumns)[number]; | |||
|
|
|||
| export const defaultRunColumns: RunColumn[] = [...runColumns]; | |||
| export const defaultRunColumns: RunColumn[] = runColumns.slice(0, -1); | |||
There was a problem hiding this comment.
nit: might be worth explicitly filtering out "archived" to avoid issues if the array gets reordered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-304
Description
This adds the archived column to the columns api. It also updates the flat runs view to handle showing the archived state of runs and ensures the archived definition matches the show archived behavior.
Test Plan
When viewing the column list for the new experiment list, the searches view, and the runs view, the user should see the "archived" column in the general tab.
Checklist
docs/release-notes/See Release Note for details.