feat: Add endpoints for search actions #9990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master/internal/api_search.go
Outdated
| @@ -169,3 +169,230 @@ func (a *apiServer) DeleteSearchTag( | |||
| } | |||
| return &res, nil | |||
| } | |||
|
|
|||
| func BulkFiltersSearchtToExperiment(filter *apiv2.BulkSearchFilters) *apiv1.BulkExperimentFilters { | |||
There was a problem hiding this comment.
Small typo here -- hopefully a tool can help rename it (F2 in VSCode, or find+replace would probably do it in this case)
AmanuelAaron
requested review from
carolinaecalderon
and removed request for
a team
added 2 commits
September 30, 2024 10:15
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/ET-684/run-centric-api #9990 +/- ##
===================================================================
- Coverage 54.54% 40.59% -13.95%
===================================================================
Files 1256 116 -1140
Lines 156852 9614 -147238
Branches 3601 0 -3601
===================================================================
- Hits 85551 3903 -81648
+ Misses 71168 5711 -65457
+ Partials 133 0 -133
Flags with carried forward coverage won't be shown. Click here to find out more. |
| return &res, nil | ||
| } | ||
|
|
||
| func (a *apiServer) DeleteSearches(ctx context.Context, req *apiv2.DeleteSearchesRequest, |
There was a problem hiding this comment.
These endpoints are essentially wrappers around already tested endpoints. Added a test for the newly added bulk conversion filter function
jesse-amano-hpe
approved these changes
Oct 1, 2024
jesse-amano-hpe
force-pushed
the
feature/ET-684/run-centric-api
branch
from
41107a3
to
57b7c87
Compare
carolinaecalderon
approved these changes
Oct 3, 2024
AmanuelAaron
merged commit 61540be
into
feature/ET-684/run-centric-api
64 of 83 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-706
ET-707
ET-708
ET-710
ET-711
ET-712
ET-713
ET-714
ET-715
ET-716
ET-717
ET-718
ET-719
ET-721
Description
Adding archive, unarchive, pause, resume, delete, kill with bulk action
Test Plan
Existing tests should pass
Checklist
docs/release-notes/See Release Note for details.