Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default elastic geoip to disabled and merge elastic environment #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikwilson
Copy link
Contributor

Improves elastic behavior by merging in environment changes and defaulting geoip downloading to false.

"logger.level": "WARN",
"ingest.geoip.downloader.enabled": "false",
}
| config.get(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this syntax requires py 3.9 and I believe we still run on 3.7 and 3.8 sometimes, so I'd suggest using some other way to merge dicts e.g.

    {
                "discovery.type": "single-node",
                "cluster.routing.allocation.disk.threshold_enabled": "false",
                "logger.level": "WARN",
                "ingest.geoip.downloader.enabled": "false",
                **config.get(....
            }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants