Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ethers-v5] Export types #286

Merged
merged 8 commits into from
Oct 11, 2020
Merged

[Ethers-v5] Export types #286

merged 8 commits into from
Oct 11, 2020

Conversation

krzkaczor
Copy link
Member

Closes: #278

@krzkaczor
Copy link
Member Author

@zemse can you test in on your codebase before I release? I will mark it as major update since formatting WILL change (breaking changes in prettier). I think it's the only sane thing to do...

@zemse
Copy link
Contributor

zemse commented Oct 10, 2020

I used this on the code base, it works fine including the exporting types from index.ts.

I think it can be worth mentioning that projects that use this new version need typescript>=3.8. New projects would have that but old projects will need to upgrade their typescript.

@krzkaczor
Copy link
Member Author

@zemse thanks for testing! I added some more fixes and gonna release it in a sec.

@krzkaczor krzkaczor merged commit 38123bb into master Oct 11, 2020
@krzkaczor krzkaczor deleted the kk/ethers-export-types branch October 11, 2020 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ethers-v5] Contract types not exported in generated index.ts
2 participants