Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ethers-v6): correctly type event listener #884

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pocin
Copy link

@pocin pocin commented Nov 2, 2023

fixes #867

Not sure about the broader implications of this, but when i made this change to the generated file it correctly types the last event listener arg so one can do

  contract.on(
    contract.filters.Swap,
    async (
      address,
      fundsOwner,
      userSellTokenAmount,
      userBuyTokenAmount,
      event
    ) => {
      console.log(event.log.transactionHash) // this
  })

seems to be working fine in my script so far

Copy link

changeset-bot bot commented Nov 2, 2023

⚠️ No Changeset found

Latest commit: b1512f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ethers-v6: wrong type generated for listening to contract events
1 participant