Skip to content
This repository has been archived by the owner on Dec 26, 2020. It is now read-only.

Remove deprecated UseLogin option #141

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

syhe
Copy link

@syhe syhe commented Nov 6, 2017

Since OpenSSH 7.4/7.4p1 (2016-12-19)[0] (The default in Debian Stretch,
CentOS 7 and others) the "UseLogin" option has been deprecated.

Setting this option originally prevented usage of a "traditional"
/usr/sbin/login-based login – but has been set to "no" by default since
quite a while, so even if this role would be applied on a host with an
older OpenSSH version, the default value should still be save.

Fixes #140

  1. https://www.openssh.com/txt/release-7.4

Since OpenSSH 7.4/7.4p1 (2016-12-19)[0] (The default in Debian Stretch,
CentOS 7 and others) the "UseLogin" option has been deprecated.

Setting this option originally prevented usage of a "traditional"
/usr/sbin/login-based login – but has been set to "no" by default since
quite a while, so even if this role would be applied on a host with an
older OpenSSH version, the default value should still be save.

Fixes dev-sec#140

0. https://www.openssh.com/txt/release-7.4
@rndmh3ro rndmh3ro self-assigned this Nov 6, 2017
@bachp
Copy link
Contributor

bachp commented Nov 20, 2017

@rndmh3ro Is there a reason this doesn't get merged?

@rndmh3ro
Copy link
Member

I haven't had time to look at this PR again, sorry.
I was thinking about about what would happen to older ssh-versions where this option is not deprecated. One could set this option to yes, therefore weaken the security. But it's disabled by default and if one uses this module, you have to deliberatly set it to yes.

@rndmh3ro rndmh3ro merged commit 48b5b58 into dev-sec:master Nov 20, 2017
@alval5280
Copy link

@rndmh3ro
Copy link
Member

@alval5280 yes, that's expected. As I wrote in my previous comment: "One could set this option to yes, therefore weaken the security. But it's disabled by default and if one uses this module, you have to deliberatly set it to yes."

So we're stuck for now with this broken test, until it's fixed here: dev-sec/ssh-baseline#95

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants