Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RH family: adapt some settings, as RH has better defaults #177

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

artem-sidorenko
Copy link
Member

dev-sec/linux-baseline#82

Its WIP as the linux-baseline PR is not merged yet

@coveralls
Copy link

coveralls commented Oct 31, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 944a1a2 on redhat into ab5a27d on master.

@shoekstra
Copy link
Contributor

Hi @artem-sidorenko,

Is this ready to merge? the linux-baseline PR has been merged and the puppet and ansible one are done, would be good to get these fixes into the Supermarket.

Cheers,

@artem-sidorenko
Copy link
Member Author

@shoekstra I want to add the fix with log permissions (see CI details) here in order to get the CI tests green. I'll do that as soon as I have time, hopefully this week.

@shoekstra
Copy link
Contributor

Hi @artem-sidorenko, as this PR only addresses rhel related updates in dev-sec/linux-baseline#82 I would be in favour of merging this as is because the related tests are passing and then fixing the non-rhel failed tests in a separate PR, something I'm happy to help with if you like? Alternatively I could create a separate PR for the non-rhel tests so long and then merge them all when ready?

Thoughts?

@artem-sidorenko
Copy link
Member Author

@shoekstra fair enough. Would you provide another PR, which fixes the failing log-related things? If yes, I would merge this PR

@shoekstra
Copy link
Contributor

@artem-sidorenko yup!

@artem-sidorenko artem-sidorenko changed the title WIP: RH family: adapt some settings, as RH has better defaults RH family: adapt some settings, as RH has better defaults Nov 9, 2017
@artem-sidorenko artem-sidorenko merged commit 0476764 into master Nov 9, 2017
@artem-sidorenko artem-sidorenko deleted the redhat branch November 9, 2017 10:57
@artem-sidorenko
Copy link
Member Author

@shoekstra here you are:-)

@shoekstra
Copy link
Contributor

I'll get started then 😃 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants