added ability to use template cookbook for login.defs #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed the login.defs file has a lot of comments and such. A custom template would allow an org to achieve more customization. |
artem-sidorenko
requested changes
Jun 25, 2018
There was a problem hiding this comment.
@ekelson-bcove thanks for this PR! May I ask you to remove the change of cookbook version?
metadata.rb
Outdated
| @@ -22,7 +22,7 @@ | |||
| license 'Apache-2.0' | |||
| description 'Installs and configures operating system hardening' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '3.1.0' | |||
There was a problem hiding this comment.
@ekelson-bcove please do not bump the cookbook version. This is done by maintainers before the release is done
|
Of course. How do you want me to remove? Another pull request or want to
just do that upstream.
…On Mon, Jun 25, 2018 at 2:53 AM Artem Sidorenko ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@ekelson-bcove <https://github.com/ekelson-bcove> thanks for this PR! May
I ask you to remove the change of cookbook version?
------------------------------
In metadata.rb
<#217 (comment)>
:
> @@ -22,7 +22,7 @@
license 'Apache-2.0'
description 'Installs and configures operating system hardening'
long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
-version '3.1.0'
@ekelson-bcove <https://github.com/ekelson-bcove> please do not bump the
cookbook version. This is done by maintainers before the release is done
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#217 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATxPa3wDli3I20g4o5Ivdlftoev-9goaks5uAIjigaJpZM4UbPZx>
.
|
|
Fixed above |
|
@ekelson-bcove thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.