Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let os_hardening::sysctl make decisions about system_environment #276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelw
Copy link

@michaelw michaelw commented Jun 4, 2021

This disables a few sysctls that do not apply in LXC and docker
environments, without affecting the rest.

This disables a few sysctls that do not apply in LXC and docker
environments, without affecting the rest.
@mcgege
Copy link
Member

mcgege commented Jun 6, 2021

@michaelw Well, for me it looks like you have changed the logic that way: If $enable_sysctl_config is true (which is the default) then the class os_hardening::sysctl is always applied, independend of the environment. That means that most of sysctl settings are set also in container environment, and only a few are skipped.

I don't think that's the way it should be ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants