Move attribute to spec as local var #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to local variable to avoid breaking test when passing additional attributes file without max_auth_tries. Also refactored variable to sshd_max_auth_retries for clarity Signed-off-by: kiwivogel <[email protected]>
Signed-off-by: kiwivogel <[email protected]>
Signed-off-by: kiwivogel <[email protected]>
chris-rock
approved these changes
Sep 19, 2019
There was a problem hiding this comment.
Uh, I am sorry we missed this. This is a must-have-fix. Thank you @kiwivogel 🥇
schurzi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an unwanted sideeffect of #138 where passing an attributes.yml to inspec that doesn't contain max_auth_tries it breaks the test. This change solves that, you can now still override the attribute if you need more or less tries but you can now pass attributes again without explicitly repeating the default value (2). Also refactors to a more clear attribute name.