ubuntu versions #151
Merged
ubuntu versions #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add recent ubuntu versions to get the correct algorithms list. Signed-off-by: Michée Lengronne <[email protected]>
micheelengronne
force-pushed
the
micheelengronne-patch-1
branch
from
abf8286
to
6581303
Compare
|
@chris-rock or @artem-sidorenko can you check please ? I just added the more recent ubuntu versions to ensure compatibility with them. |
|
That is great, should we add 20.04 as well? Going forward we may want to parse the Ubuntu version to check only for the major version being greater than 14. |
Signed-off-by: Michée Lengronne <[email protected]>
micheelengronne
force-pushed
the
micheelengronne-patch-1
branch
from
9324bef
to
ade9096
Compare
|
I tried smthg. As there is only 2 cases for ubuntu, I just set the case that is not the default. |
Signed-off-by: Michée Lengronne <[email protected]>
micheelengronne
force-pushed
the
micheelengronne-patch-1
branch
from
04bdb64
to
f3ff5b1
Compare
Signed-off-by: Michée Lengronne <[email protected]>
micheelengronne
force-pushed
the
micheelengronne-patch-1
branch
from
51a343e
to
626f59f
Compare
|
@chris-rock is it ok to merge ? |
chris-rock
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recent ubuntu versions to get the correct algorithms list.