Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release github workflow #157

Merged
merged 4 commits into from
May 11, 2020
Merged

Release github workflow #157

merged 4 commits into from
May 11, 2020

Conversation

micheelengronne
Copy link
Member

Update inspec.yml prior to generate changelog. That way, the changelog push will do for both.

Update inspec.yml prior to generate changelog. That way, the changelog push will do for both.

Signed-off-by: Michée Lengronne <[email protected]>
@rndmh3ro
Copy link
Member

That way, the changelog push will do for both.

There is no push in that action. The changelog only gets generated, not commited or pushed.
To push something, you need another task, like here: https://github.com/dev-sec/ansible-ssh-hardening/blob/master/.github/workflows/changelog.yml#L25

Signed-off-by: Michée Lengronne <[email protected]>
@micheelengronne
Copy link
Member Author

Ok. I modified the order and there is 2 pushs now. One for the changelog and one for inspec.yml.

@micheelengronne
Copy link
Member Author

Hum, is it better to have an atomicity (changelog + inspec.yml) or to create 2 commits (one for each) ?

@rndmh3ro
Copy link
Member

Hum, is it better to have an atomicity (changelog + inspec.yml) or to create 2 commits (one for each) ?

I'm for atomicity. If the commit or push fails, we won't have one dangling commit int the repo.

Signed-off-by: Michée Lengronne <[email protected]>
Signed-off-by: Michée Lengronne <[email protected]>
@micheelengronne micheelengronne merged commit 54afd07 into master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants