-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add basic support for Ubuntu 22 #204
Conversation
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it seems correct.
I just checked the differences for defaults MACs, Kex and Ciphers between Ubuntu 18, 20 and 22. We should probably add some new variables for the different ssh-versions, add the defaults and then substracts known weak ciphers (if needed). @schurzi what do you think? ssh-versions:
|
Thanks for compiling the lists @rndmh3ro. I have checked them with our Ansible Collection, a Test VM and at CIS Benchmark. If I account for insecure settings, almost all lists are identical. We currently do our checks based on some specific key versions of OpenSSH, every time there is a substantial new algorithm we want to support we create a new variable and extend our logic in the library. Currently I do not see the need to introduce a new variable for 8.9, the settings from 8.5 still seem applicable. Regarding your thoughts, I think I am in favor of rewriting our checks to a version based approach. I also think I want to reverse the function logic. But I kind of want to handle this in a separate Issue/PR. |
opened new issue #205 for that |
This adds basic support for Ubuntu 22. I have not checked if there are newer (better) supported ciphers. I assume, the slightly older ones are still ok for a first update. Currently this control fails on Ubuntu 22 after hardening with our Ansible Collection is applied.
Signed-off-by: Martin Schurz [email protected]