Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify crypto library #209

Merged
merged 1 commit into from
Oct 24, 2022
Merged

simplify crypto library #209

merged 1 commit into from
Oct 24, 2022

Conversation

rndmh3ro
Copy link
Member

Signed-off-by: Sebastian Gumprich [email protected]

Signed-off-by: Sebastian Gumprich <[email protected]>
@rndmh3ro
Copy link
Member Author

Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like the amount of code we can save here.
One small thing regarding the ssh_version function, we are using the ssh client binary but it may be, that a system only has sshd installed.

@rndmh3ro
Copy link
Member Author

Successfully tested here: https://github.com/dev-sec/ansible-collection-hardening/pull/589/checks

nice, I like the amount of code we can save here. One small thing regarding the ssh_version function, we are using the ssh client binary but it may be, that a system only has sshd installed.

sshd sadly does not have an option to print its version (you could run sshd with an invalid option to get the version, but this also throws an error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update detection of applicable ciphers/kex/mac to use OpenSSH version instead of OS version
2 participants