Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing inspec tests for ubuntu hosts #63

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Fixing inspec tests for ubuntu hosts #63

merged 1 commit into from
Aug 19, 2016

Conversation

attachmentgenie
Copy link
Member

@attachmentgenie attachmentgenie commented Aug 19, 2016

In the latest version of inspec (0.30.0) ubuntu nodes are classified as being part of the Debian family (and not in a family of its own).

This pull requests fixes this shortcoming (tested on 12.04, 14.04, 16.04)

@@ -29,25 +29,22 @@ def valid_ciphers

# adjust ciphers based on OS + release
case inspec.os[:family]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets just switch from inspec.os[:family] to inspec.os[:name]

@chris-rock
Copy link
Member

Great finding @attachmentgenie InSpec introduced the inspec.os[:name], so that we have more information available:

inspec detect

== Operating System Details

Name:      mac_os_x
Family:    darwin
Release:   10.10.5
Arch:      x86_64

or in json

inspec detect --format 'json'
{"name":"mac_os_x","family":"darwin","release":"10.10.5","arch":"x86_64"}

@attachmentgenie
Copy link
Member Author

attachmentgenie commented Aug 19, 2016

that would actually be the much simpler solution to this problem, let me see i can fix that.

update: fixed! as well as the original comment

@atomic111
Copy link
Member

@attachmentgenie please rebase your pr, that we get a green light and can merge it

@attachmentgenie
Copy link
Member Author

your wish is my command

@chris-rock chris-rock merged commit 7dc596a into dev-sec:master Aug 19, 2016
@chris-rock
Copy link
Member

Thanks @attachmentgenie for this quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants