Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto find cudnn version #1126

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

auto find cudnn version #1126

wants to merge 8 commits into from
+74 −72

Conversation

prathameshzarkar9
Copy link
Contributor

Issue 718
Version '8.9.5.29-1+cuda12.1' for 'libcudnn8' was not found

Feature Name

  • nvidia-cuda

Changelog

  • Changes to install.sh for features issue 718 to autofind the cudnn version if cuda version is below 12.3
  • Changes to scenario.json to test the older version of cuda is installing a latest cudnn version automatically

Checklist

  • if pass version as 12.2 and below then it is finding the cudnn version

@prathameshzarkar9 prathameshzarkar9 requested a review from a team as a code owner September 23, 2024 10:20
@prathameshzarkar9 prathameshzarkar9 mentioned this pull request Sep 23, 2024
Open
@prathameshzarkar9 prathameshzarkar9 self-assigned this Sep 25, 2024
@samruddhikhandale samruddhikhandale linked an issue Sep 25, 2024 that may be closed by this pull request
Version '8.9.5.29-1+cuda12.1' for 'libcudnn8' was not found #718
Open
samruddhikhandale
samruddhikhandale previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a minor comment

src/nvidia-cuda/devcontainer-feature.json Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Oct 17, 2024
View reviewed changes
test/nvidia-cuda/scenarios.json
"installCudnnDev": true,
"installToolkit": true,
"cudaVersion": "12.5",
"cudnnVersion": "9.4.0.58"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep few scenarios to validate cudnnVersion where it is NOT automatic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@prathameshzarkar9 prathameshzarkar9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version '8.9.5.29-1+cuda12.1' for 'libcudnn8' was not found
2 participants
@prathameshzarkar9 @samruddhikhandale